| From cc9cdcbed962a2c04c5fc8b9d00772ce2fa87c99 Mon Sep 17 00:00:00 2001 |
| From: Aya Levin <ayal@mellanox.com> |
| Date: Wed, 23 Oct 2019 12:57:54 +0300 |
| Subject: [PATCH] net/mlx5e: Initialize on stack link modes bitmap |
| |
| commit 926b37f76fb0a22fe93c8873c819fd167180e85c upstream. |
| |
| Initialize link modes bitmap on stack before using it, otherwise the |
| outcome of ethtool set link ksettings might have unexpected values. |
| |
| Fixes: 4b95840a6ced ("net/mlx5e: Fix matching of speed to PRM link modes") |
| Signed-off-by: Aya Levin <ayal@mellanox.com> |
| Signed-off-by: Saeed Mahameed <saeedm@mellanox.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c |
| index 2e177f3f403b..21aeb0cf4b54 100644 |
| --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c |
| +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c |
| @@ -1000,7 +1000,7 @@ static bool ext_link_mode_requested(const unsigned long *adver) |
| { |
| #define MLX5E_MIN_PTYS_EXT_LINK_MODE_BIT ETHTOOL_LINK_MODE_50000baseKR_Full_BIT |
| int size = __ETHTOOL_LINK_MODE_MASK_NBITS - MLX5E_MIN_PTYS_EXT_LINK_MODE_BIT; |
| - __ETHTOOL_DECLARE_LINK_MODE_MASK(modes); |
| + __ETHTOOL_DECLARE_LINK_MODE_MASK(modes) = {0,}; |
| |
| bitmap_set(modes, MLX5E_MIN_PTYS_EXT_LINK_MODE_BIT, size); |
| return bitmap_intersects(modes, adver, __ETHTOOL_LINK_MODE_MASK_NBITS); |
| -- |
| 2.7.4 |
| |
