| From abe783be89f694218ecdcc79b9154936bec9d941 Mon Sep 17 00:00:00 2001 |
| From: Colin Ian King <colin.king@canonical.com> |
| Date: Tue, 14 Jan 2020 14:54:48 +0000 |
| Subject: [PATCH] net/wan/fsl_ucc_hdlc: fix out of bounds write on array |
| utdm_info |
| |
| commit ddf420390526ede3b9ff559ac89f58cb59d9db2f upstream. |
| |
| Array utdm_info is declared as an array of MAX_HDLC_NUM (4) elements |
| however up to UCC_MAX_NUM (8) elements are potentially being written |
| to it. Currently we have an array out-of-bounds write error on the |
| last 4 elements. Fix this by making utdm_info UCC_MAX_NUM elements in |
| size. |
| |
| Addresses-Coverity: ("Out-of-bounds write") |
| Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c |
| index ca0f3be2b6bf..aef7de225783 100644 |
| --- a/drivers/net/wan/fsl_ucc_hdlc.c |
| +++ b/drivers/net/wan/fsl_ucc_hdlc.c |
| @@ -73,7 +73,7 @@ static struct ucc_tdm_info utdm_primary_info = { |
| }, |
| }; |
| |
| -static struct ucc_tdm_info utdm_info[MAX_HDLC_NUM]; |
| +static struct ucc_tdm_info utdm_info[UCC_MAX_NUM]; |
| |
| static int uhdlc_init(struct ucc_hdlc_private *priv) |
| { |
| -- |
| 2.7.4 |
| |