| From e5895efcbd0dffb822be1eb3156d7d49457b37b6 Mon Sep 17 00:00:00 2001 |
| From: Brett Creeley <brett.creeley@intel.com> |
| Date: Mon, 10 Feb 2020 10:59:18 -0800 |
| Subject: [PATCH] i40e: Fix the conditional for i40e_vc_validate_vqs_bitmaps |
| |
| commit f27f37a04a69890ac85d9155f03ee2d23b678d8f upstream. |
| |
| Commit d9d6a9aed3f6 ("i40e: Fix virtchnl_queue_select bitmap |
| validation") introduced a necessary change for verifying how queue |
| bitmaps from the iavf driver get validated. Unfortunately, the |
| conditional was reversed. Fix this. |
| |
| Fixes: d9d6a9aed3f6 ("i40e: Fix virtchnl_queue_select bitmap validation") |
| Signed-off-by: Brett Creeley <brett.creeley@intel.com> |
| Tested-by: Andrew Bowers <andrewx.bowers@intel.com> |
| Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |
| index a49da7261758..1b1e60b86f31 100644 |
| --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |
| +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |
| @@ -2348,7 +2348,7 @@ static int i40e_vc_enable_queues_msg(struct i40e_vf *vf, u8 *msg) |
| goto error_param; |
| } |
| |
| - if (i40e_vc_validate_vqs_bitmaps(vqs)) { |
| + if (!i40e_vc_validate_vqs_bitmaps(vqs)) { |
| aq_ret = I40E_ERR_PARAM; |
| goto error_param; |
| } |
| @@ -2405,7 +2405,7 @@ static int i40e_vc_disable_queues_msg(struct i40e_vf *vf, u8 *msg) |
| goto error_param; |
| } |
| |
| - if (i40e_vc_validate_vqs_bitmaps(vqs)) { |
| + if (!i40e_vc_validate_vqs_bitmaps(vqs)) { |
| aq_ret = I40E_ERR_PARAM; |
| goto error_param; |
| } |
| -- |
| 2.7.4 |
| |
