| From fb87cd347da41bf7f4316412147e3ae925b1732e Mon Sep 17 00:00:00 2001 |
| From: zhanglin <zhang.lin16@zte.com.cn> |
| Date: Sat, 26 Oct 2019 15:54:16 +0800 |
| Subject: [PATCH] net: Zeroing the structure ethtool_wolinfo in |
| ethtool_get_wol() |
| |
| commit 5ff223e86f5addbfae26419cbb5d61d98f6fbf7d upstream. |
| |
| memset() the structure ethtool_wolinfo that has padded bytes |
| but the padded bytes have not been zeroed out. |
| |
| Signed-off-by: zhanglin <zhang.lin16@zte.com.cn> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/net/core/ethtool.c b/net/core/ethtool.c |
| index 4d1011b2e24f..427ae856a8ac 100644 |
| --- a/net/core/ethtool.c |
| +++ b/net/core/ethtool.c |
| @@ -1395,11 +1395,13 @@ static int ethtool_reset(struct net_device *dev, char __user *useraddr) |
| |
| static int ethtool_get_wol(struct net_device *dev, char __user *useraddr) |
| { |
| - struct ethtool_wolinfo wol = { .cmd = ETHTOOL_GWOL }; |
| + struct ethtool_wolinfo wol; |
| |
| if (!dev->ethtool_ops->get_wol) |
| return -EOPNOTSUPP; |
| |
| + memset(&wol, 0, sizeof(struct ethtool_wolinfo)); |
| + wol.cmd = ETHTOOL_GWOL; |
| dev->ethtool_ops->get_wol(dev, &wol); |
| |
| if (copy_to_user(useraddr, &wol, sizeof(wol))) |
| -- |
| 2.7.4 |
| |