| From 60098ec4af792a2e11c7134d021cfb0ab7e20fba Mon Sep 17 00:00:00 2001 |
| From: Dongdong Liu <liudongdong3@huawei.com> |
| Date: Thu, 23 Jan 2020 16:26:31 +0800 |
| Subject: [PATCH] PCI/AER: Initialize aer_fifo |
| |
| commit d95f20c4f07020ebc605f3b46af4b6db9eb5fc99 upstream. |
| |
| Previously we did not call INIT_KFIFO() for aer_fifo. This leads to |
| kfifo_put() sometimes returning 0 (queue full) when in fact it is not. |
| |
| It is easy to reproduce the problem by using aer-inject: |
| |
| $ aer-inject -s :82:00.0 multiple-corr-nonfatal |
| |
| The content of the multiple-corr-nonfatal file is as below: |
| |
| AER |
| COR RCVR |
| HL 0 1 2 3 |
| AER |
| UNCOR POISON_TLP |
| HL 4 5 6 7 |
| |
| Fixes: 27c1ce8bbed7 ("PCI/AER: Use kfifo for tracking events instead of reimplementing it") |
| Link: https://lore.kernel.org/r/1579767991-103898-1-git-send-email-liudongdong3@huawei.com |
| Signed-off-by: Dongdong Liu <liudongdong3@huawei.com> |
| Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c |
| index b45bc47d04fe..271aecfbc3bf 100644 |
| --- a/drivers/pci/pcie/aer.c |
| +++ b/drivers/pci/pcie/aer.c |
| @@ -1387,6 +1387,7 @@ static int aer_probe(struct pcie_device *dev) |
| return -ENOMEM; |
| |
| rpc->rpd = port; |
| + INIT_KFIFO(rpc->aer_fifo); |
| set_service_data(dev, rpc); |
| |
| status = devm_request_threaded_irq(device, dev->irq, aer_irq, aer_isr, |
| -- |
| 2.7.4 |
| |
