| From 4c9a0a35cd3c2984a3c58bc22c7214472d01c9c9 Mon Sep 17 00:00:00 2001 |
| From: Thomas Gleixner <tglx@linutronix.de> |
| Date: Wed, 9 Dec 2009 14:35:10 +0100 |
| Subject: [PATCH] audit: Do not send uninitialized data for AUDIT_TTY_GET |
| |
| commit 4c9a0a35cd3c2984a3c58bc22c7214472d01c9c9 in tip. |
| |
| audit_receive_msg() sends uninitialized data for AUDIT_TTY_GET when |
| the task was not found. |
| |
| Send reply only when task was found. |
| |
| Signed-off-by: Thomas Gleixner <tglx@linutronix.de> |
| Cc: Al Viro <viro@zeniv.linux.org.uk> |
| Cc: Eric Paris <eparis@redhat.com> |
| |
| diff --git a/kernel/audit.c b/kernel/audit.c |
| index 5feed23..bf307dd 100644 |
| --- a/kernel/audit.c |
| +++ b/kernel/audit.c |
| @@ -891,8 +891,10 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) |
| spin_unlock_irq(&tsk->sighand->siglock); |
| } |
| read_unlock(&tasklist_lock); |
| - audit_send_reply(NETLINK_CB(skb).pid, seq, AUDIT_TTY_GET, 0, 0, |
| - &s, sizeof(s)); |
| + |
| + if (!err) |
| + audit_send_reply(NETLINK_CB(skb).pid, seq, |
| + AUDIT_TTY_GET, 0, 0, &s, sizeof(s)); |
| break; |
| } |
| case AUDIT_TTY_SET: { |
| -- |
| 1.7.1.1 |
| |
