tools/perf: fixies Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index d2d672f..6d423d9 100644 --- a/tools/perf/util/callchain.c +++ b/tools/perf/util/callchain.c
@@ -1832,7 +1832,7 @@ int sample__for_each_callchain_node(struct thread *thread, struct evsel *evsel, int sample__merge_deferred_callchain(struct perf_sample *sample_orig, struct perf_sample *sample_callchain) { - u64 nr_orig = sample_orig->callchain->nr - PERF_DEFERRED_ITEMS; + u64 nr_orig = sample_orig->callchain->nr - 1; u64 nr_deferred = sample_callchain->callchain->nr; struct ip_callchain *callchain;
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index ada0b10..d35265b 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c
@@ -1520,6 +1520,7 @@ void evsel__config(struct evsel *evsel, struct record_opts *opts, attr->mmap2 = track && !perf_missing_features.mmap2; attr->comm = track; attr->build_id = track && opts->build_id; + attr->defer_output = track && !perf_missing_features.defer_callchain; /* * ksymbol is tracked separately with text poke because it needs to be @@ -2206,8 +2207,10 @@ static int __evsel__prepare_open(struct evsel *evsel, struct perf_cpu_map *cpus, static void evsel__disable_missing_features(struct evsel *evsel) { - if (perf_missing_features.defer_callchain) + if (perf_missing_features.defer_callchain) { evsel->core.attr.defer_callchain = 0; + evsel->core.attr.defer_output = 0; + } if (perf_missing_features.inherit_sample_read && evsel->core.attr.inherit && (evsel->core.attr.sample_type & PERF_SAMPLE_READ)) evsel->core.attr.inherit = 0; @@ -2489,6 +2492,7 @@ static bool evsel__detect_missing_features(struct evsel *evsel, struct perf_cpu perf_missing_features.defer_callchain = true; pr_debug2("switching off deferred callchain support\n"); attr.defer_callchain = false; + attr.defer_output = false; attr.sample_type = 0; attr.inherit = true; @@ -3255,8 +3259,8 @@ int evsel__parse_sample(struct evsel *evsel, union perf_event *event, return -EFAULT; sz = data->callchain->nr * sizeof(u64); if (evsel->core.attr.defer_callchain && - data->callchain->nr >= PERF_DEFERRED_ITEMS && - data->callchain->ips[data->callchain->nr - PERF_DEFERRED_ITEMS] == PERF_CONTEXT_USER_DEFERRED) { + data->callchain->nr >= 2 && + data->callchain->ips[data->callchain->nr - 2] == PERF_CONTEXT_USER_DEFERRED) { data->deferred_callchain = true; data->deferred_cookie = data->callchain->ips[data->callchain->nr - 1]; }
diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c index abfd9b9..741c3d6 100644 --- a/tools/perf/util/perf_event_attr_fprintf.c +++ b/tools/perf/util/perf_event_attr_fprintf.c
@@ -344,6 +344,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr, PRINT_ATTRf(remove_on_exec, p_unsigned); PRINT_ATTRf(sigtrap, p_unsigned); PRINT_ATTRf(defer_callchain, p_unsigned); + PRINT_ATTRf(defer_output, p_unsigned); PRINT_ATTRn("{ wakeup_events, wakeup_watermark }", wakeup_events, p_unsigned, false); PRINT_ATTRf(bp_type, p_unsigned);