commit d81efd66106c03771ffc8637855a6ec24caa6350
author Konstantin Meskhidze <konstantin.meskhidze@huawei.com> Tue Sep 05 18:12:22 2023 +0800
committer Richard Weinberger <richard@nod.at> Sat Oct 28 23:18:12 2023 +0200
tree b78dfa9992f9b4791c1dfbb18af36abb78154615
parent ac085cfe57df2cc1d7a5c4c5e64b8780c8ad452f

ubifs: fix possible dereference after free

'old_idx' could be dereferenced after free via 'rb_link_node' function
call.

Fixes: b5fda08ef213 ("ubifs: Fix memleak when insert_old_idx() failed")
Co-developed-by: Ivanov Mikhail <ivanov.mikhail1@huawei-partners.com>
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

fs/ubifs/tnc.c

diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c
index 6b7d95b..f4728e6 100644
--- a/fs/ubifs/tnc.c
+++ b/fs/ubifs/tnc.c
@@ -65,6 +65,7 @@
 		else {
 			ubifs_err(c, "old idx added twice!");
 			kfree(old_idx);
+			return;
 		}
 	}
 	rb_link_node(&old_idx->rb, parent, p);