| From d45963a93c1495e9f1338fde91d0ebba8fd22474 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Date: Thu, 19 Feb 2026 15:34:35 +0100 |
| Subject: leds: qcom-lpg: Check for array overflow when selecting the high resolution |
| |
| From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| commit d45963a93c1495e9f1338fde91d0ebba8fd22474 upstream. |
| |
| When selecting the high resolution values from the array, FIELD_GET() is |
| used to pull from a 3 bit register, yet the array being indexed has only |
| 5 values in it. Odds are the hardware is sane, but just to be safe, |
| properly check before just overflowing and reading random data and then |
| setting up chip values based on that. |
| |
| Cc: stable <stable@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Link: https://patch.msgid.link/2026021934-nearby-playroom-036b@gregkh |
| Signed-off-by: Lee Jones <lee@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/leds/rgb/leds-qcom-lpg.c | 7 ++++++- |
| 1 file changed, 6 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/leds/rgb/leds-qcom-lpg.c |
| +++ b/drivers/leds/rgb/leds-qcom-lpg.c |
| @@ -1273,7 +1273,12 @@ static int lpg_pwm_get_state(struct pwm_ |
| return ret; |
| |
| if (chan->subtype == LPG_SUBTYPE_HI_RES_PWM) { |
| - refclk = lpg_clk_rates_hi_res[FIELD_GET(PWM_CLK_SELECT_HI_RES_MASK, val)]; |
| + unsigned int clk_idx = FIELD_GET(PWM_CLK_SELECT_HI_RES_MASK, val); |
| + |
| + if (clk_idx >= ARRAY_SIZE(lpg_clk_rates_hi_res)) |
| + return -EINVAL; |
| + |
| + refclk = lpg_clk_rates_hi_res[clk_idx]; |
| resolution = lpg_pwm_resolution_hi_res[FIELD_GET(PWM_SIZE_HI_RES_MASK, val)]; |
| } else { |
| refclk = lpg_clk_rates[FIELD_GET(PWM_CLK_SELECT_MASK, val)]; |