| From 3f2e70decb3a211c2e89487a4410725eb6c8100f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 2 Jul 2024 17:34:11 +0000 |
| Subject: iio: adc: ad7606: fix standby gpio state to match the documentation |
| |
| From: Guillaume Stols <gstols@baylibre.com> |
| |
| [ Upstream commit 059fe4f8bbdf5cad212e1aeeb3e8968c80b9ff3b ] |
| |
| The binding's documentation specifies that "As the line is active low, it |
| should be marked GPIO_ACTIVE_LOW". However, in the driver, it was handled |
| the opposite way. This commit sets the driver's behaviour in sync with the |
| documentation |
| |
| Fixes: 722407a4e8c0 ("staging:iio:ad7606: Use GPIO descriptor API") |
| Signed-off-by: Guillaume Stols <gstols@baylibre.com> |
| Reviewed-by: Nuno Sa <nuno.sa@analog.com> |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/iio/adc/ad7606.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c |
| index 5e41df6531581..b1b0ac47e3bc8 100644 |
| --- a/drivers/iio/adc/ad7606.c |
| +++ b/drivers/iio/adc/ad7606.c |
| @@ -422,7 +422,7 @@ static int ad7606_request_gpios(struct ad7606_state *st) |
| return PTR_ERR(st->gpio_range); |
| |
| st->gpio_standby = devm_gpiod_get_optional(dev, "standby", |
| - GPIOD_OUT_HIGH); |
| + GPIOD_OUT_LOW); |
| if (IS_ERR(st->gpio_standby)) |
| return PTR_ERR(st->gpio_standby); |
| |
| @@ -681,7 +681,7 @@ static int ad7606_suspend(struct device *dev) |
| |
| if (st->gpio_standby) { |
| gpiod_set_value(st->gpio_range, 1); |
| - gpiod_set_value(st->gpio_standby, 0); |
| + gpiod_set_value(st->gpio_standby, 1); |
| } |
| |
| return 0; |
| -- |
| 2.43.0 |
| |
