| From b898f4f869da5b9d41f297fff87aca4cd42d80b3 Mon Sep 17 00:00:00 2001 |
| From: Roel Kluin <roel.kluin@gmail.com> |
| Date: Thu, 28 May 2009 14:34:29 -0700 |
| Subject: drivers/serial/mpc52xx_uart.c: fix array overindexing check |
| |
| From: Roel Kluin <roel.kluin@gmail.com> |
| |
| commit b898f4f869da5b9d41f297fff87aca4cd42d80b3 upstream. |
| |
| The check for an overindexing of mpc52xx_uart_{ports,nodes} has an |
| off-by-one. |
| |
| Signed-off-by: Roel Kluin <roel.kluin@gmail.com> |
| Acked-by: Wolfram Sang <w.sang@pengutronix.de> |
| Acked-by: Grant Likely <grant.likely@secretlab.ca> |
| Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> |
| Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/serial/mpc52xx_uart.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/serial/mpc52xx_uart.c |
| +++ b/drivers/serial/mpc52xx_uart.c |
| @@ -988,7 +988,7 @@ mpc52xx_console_setup(struct console *co |
| pr_debug("mpc52xx_console_setup co=%p, co->index=%i, options=%s\n", |
| co, co->index, options); |
| |
| - if ((co->index < 0) || (co->index > MPC52xx_PSC_MAXNUM)) { |
| + if ((co->index < 0) || (co->index >= MPC52xx_PSC_MAXNUM)) { |
| pr_debug("PSC%x out of range\n", co->index); |
| return -EINVAL; |
| } |
