| From a2ae4cc9a16e211c8a128ba10d22a85431f093ab Mon Sep 17 00:00:00 2001 |
| From: Eric Paris <eparis@redhat.com> |
| Date: Tue, 23 Nov 2010 18:18:37 -0500 |
| Subject: inotify: stop kernel memory leak on file creation failure |
| |
| From: Eric Paris <eparis@redhat.com> |
| |
| commit a2ae4cc9a16e211c8a128ba10d22a85431f093ab upstream. |
| |
| If inotify_init is unable to allocate a new file for the new inotify |
| group we leak the new group. This patch drops the reference on the |
| group on file allocation failure. |
| |
| Reported-by: Vegard Nossum <vegard.nossum@gmail.com> |
| Signed-off-by: Eric Paris <eparis@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| fs/notify/inotify/inotify_user.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/fs/notify/inotify/inotify_user.c |
| +++ b/fs/notify/inotify/inotify_user.c |
| @@ -751,6 +751,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flag |
| if (ret >= 0) |
| return ret; |
| |
| + fsnotify_put_group(group); |
| atomic_dec(&user->inotify_devs); |
| out_free_uid: |
| free_uid(user); |
