| From 3012f43eaf7592d8121426918e43e3b5db013aff Mon Sep 17 00:00:00 2001 |
| From: "Rajashekhara, Sudhakar" <sudhakar.raj@ti.com> |
| Date: Wed, 20 Jul 2011 17:36:04 +0530 |
| Subject: ASoC: davinci: fix codec start and stop functions |
| |
| From: "Rajashekhara, Sudhakar" <sudhakar.raj@ti.com> |
| |
| commit 3012f43eaf7592d8121426918e43e3b5db013aff upstream. |
| |
| According to DM365 voice codec data sheet at [1], before starting |
| recording or playback, ADC/DAC modules should follow a reset and |
| enable cycle. Writing a 1 to the ADC/DAC bit in the register resets |
| the module and clearing the bit to 0 will enable the module. But the |
| driver seems to be doing the reverse of it. |
| |
| [1] http://focus.ti.com/lit/ug/sprufi9b/sprufi9b.pdf |
| |
| Signed-off-by: Rajashekhara, Sudhakar <sudhakar.raj@ti.com> |
| Acked-by: Liam Girdwood <lrg@ti.com> |
| Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| sound/soc/davinci/davinci-vcif.c | 8 ++++---- |
| 1 file changed, 4 insertions(+), 4 deletions(-) |
| |
| --- a/sound/soc/davinci/davinci-vcif.c |
| +++ b/sound/soc/davinci/davinci-vcif.c |
| @@ -62,9 +62,9 @@ static void davinci_vcif_start(struct sn |
| w = readl(davinci_vc->base + DAVINCI_VC_CTRL); |
| |
| if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) |
| - MOD_REG_BIT(w, DAVINCI_VC_CTRL_RSTDAC, 1); |
| + MOD_REG_BIT(w, DAVINCI_VC_CTRL_RSTDAC, 0); |
| else |
| - MOD_REG_BIT(w, DAVINCI_VC_CTRL_RSTADC, 1); |
| + MOD_REG_BIT(w, DAVINCI_VC_CTRL_RSTADC, 0); |
| |
| writel(w, davinci_vc->base + DAVINCI_VC_CTRL); |
| } |
| @@ -80,9 +80,9 @@ static void davinci_vcif_stop(struct snd |
| /* Reset transmitter/receiver and sample rate/frame sync generators */ |
| w = readl(davinci_vc->base + DAVINCI_VC_CTRL); |
| if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) |
| - MOD_REG_BIT(w, DAVINCI_VC_CTRL_RSTDAC, 0); |
| + MOD_REG_BIT(w, DAVINCI_VC_CTRL_RSTDAC, 1); |
| else |
| - MOD_REG_BIT(w, DAVINCI_VC_CTRL_RSTADC, 0); |
| + MOD_REG_BIT(w, DAVINCI_VC_CTRL_RSTADC, 1); |
| |
| writel(w, davinci_vc->base + DAVINCI_VC_CTRL); |
| } |