| From 4be7ca112141a0bfcfe8a29890743de0f313abf1 Mon Sep 17 00:00:00 2001 |
| From: Julian Anastasov <ja@ssi.bg> |
| Date: Fri, 2 Dec 2011 11:39:42 +0000 |
| Subject: ipv4: make sure RTO_ONLINK is saved in routing cache |
| |
| |
| From: Julian Anastasov <ja@ssi.bg> |
| |
| [ Upstream commit f61759e6b831a55b89e584b198c3da325e2bc379 ] |
| |
| __mkroute_output fails to work with the original tos |
| and uses value with stripped RTO_ONLINK bit. Make sure we put |
| the original TOS bits into rt_key_tos because it used to match |
| cached route. |
| |
| Signed-off-by: Julian Anastasov <ja@ssi.bg> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| --- |
| net/ipv4/route.c | 12 ++++++------ |
| 1 file changed, 6 insertions(+), 6 deletions(-) |
| |
| --- a/net/ipv4/route.c |
| +++ b/net/ipv4/route.c |
| @@ -112,7 +112,7 @@ |
| #include <net/secure_seq.h> |
| |
| #define RT_FL_TOS(oldflp4) \ |
| - ((u32)(oldflp4->flowi4_tos & (IPTOS_RT_MASK | RTO_ONLINK))) |
| + ((oldflp4)->flowi4_tos & (IPTOS_RT_MASK | RTO_ONLINK)) |
| |
| #define IP_MAX_MTU 0xFFF0 |
| |
| @@ -2430,11 +2430,11 @@ EXPORT_SYMBOL(ip_route_input_common); |
| static struct rtable *__mkroute_output(const struct fib_result *res, |
| const struct flowi4 *fl4, |
| __be32 orig_daddr, __be32 orig_saddr, |
| - int orig_oif, struct net_device *dev_out, |
| + int orig_oif, __u8 orig_rtos, |
| + struct net_device *dev_out, |
| unsigned int flags) |
| { |
| struct fib_info *fi = res->fi; |
| - u32 tos = RT_FL_TOS(fl4); |
| struct in_device *in_dev; |
| u16 type = res->type; |
| struct rtable *rth; |
| @@ -2485,7 +2485,7 @@ static struct rtable *__mkroute_output(c |
| rth->rt_genid = rt_genid(dev_net(dev_out)); |
| rth->rt_flags = flags; |
| rth->rt_type = type; |
| - rth->rt_key_tos = tos; |
| + rth->rt_key_tos = orig_rtos; |
| rth->rt_dst = fl4->daddr; |
| rth->rt_src = fl4->saddr; |
| rth->rt_route_iif = 0; |
| @@ -2535,7 +2535,7 @@ static struct rtable *__mkroute_output(c |
| static struct rtable *ip_route_output_slow(struct net *net, struct flowi4 *fl4) |
| { |
| struct net_device *dev_out = NULL; |
| - u32 tos = RT_FL_TOS(fl4); |
| + __u8 tos = RT_FL_TOS(fl4); |
| unsigned int flags = 0; |
| struct fib_result res; |
| struct rtable *rth; |
| @@ -2711,7 +2711,7 @@ static struct rtable *ip_route_output_sl |
| |
| make_route: |
| rth = __mkroute_output(&res, fl4, orig_daddr, orig_saddr, orig_oif, |
| - dev_out, flags); |
| + tos, dev_out, flags); |
| if (!IS_ERR(rth)) { |
| unsigned int hash; |
| |