| From 8660998608cfa1077e560034db81885af8e1e885 Mon Sep 17 00:00:00 2001 |
| From: Dave Kleikamp <dave.kleikamp@oracle.com> |
| Date: Fri, 6 Sep 2013 21:49:56 -0500 |
| Subject: jfs: fix error path in ialloc |
| |
| From: Dave Kleikamp <dave.kleikamp@oracle.com> |
| |
| commit 8660998608cfa1077e560034db81885af8e1e885 upstream. |
| |
| If insert_inode_locked() fails, we shouldn't be calling |
| unlock_new_inode(). |
| |
| Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com> |
| Tested-by: Michael L. Semon <mlsemon35@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/jfs/jfs_inode.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| --- a/fs/jfs/jfs_inode.c |
| +++ b/fs/jfs/jfs_inode.c |
| @@ -95,7 +95,7 @@ struct inode *ialloc(struct inode *paren |
| |
| if (insert_inode_locked(inode) < 0) { |
| rc = -EINVAL; |
| - goto fail_unlock; |
| + goto fail_put; |
| } |
| |
| inode_init_owner(inode, parent, mode); |
| @@ -156,7 +156,6 @@ struct inode *ialloc(struct inode *paren |
| fail_drop: |
| dquot_drop(inode); |
| inode->i_flags |= S_NOQUOTA; |
| -fail_unlock: |
| clear_nlink(inode); |
| unlock_new_inode(inode); |
| fail_put: |