| From 07e19dff63e3d5d6500d831e36554ac9b1b0560e Mon Sep 17 00:00:00 2001 |
| From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> |
| Date: Sun, 29 Jun 2014 16:55:02 +0300 |
| Subject: UBIFS: remove mst_mutex |
| |
| From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> |
| |
| commit 07e19dff63e3d5d6500d831e36554ac9b1b0560e upstream. |
| |
| The 'mst_mutex' is not needed since because 'ubifs_write_master()' is only |
| called on the mount path and commit path. The mount path is sequential and |
| there is no parallelism, and the commit path is also serialized - there is only |
| one commit going on at a time. |
| |
| Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/ubifs/commit.c | 2 -- |
| fs/ubifs/master.c | 7 +++---- |
| fs/ubifs/super.c | 1 - |
| fs/ubifs/ubifs.h | 2 -- |
| 4 files changed, 3 insertions(+), 9 deletions(-) |
| |
| --- a/fs/ubifs/commit.c |
| +++ b/fs/ubifs/commit.c |
| @@ -174,7 +174,6 @@ static int do_commit(struct ubifs_info * |
| if (err) |
| goto out; |
| |
| - mutex_lock(&c->mst_mutex); |
| c->mst_node->cmt_no = cpu_to_le64(c->cmt_no); |
| c->mst_node->log_lnum = cpu_to_le32(new_ltail_lnum); |
| c->mst_node->root_lnum = cpu_to_le32(zroot.lnum); |
| @@ -204,7 +203,6 @@ static int do_commit(struct ubifs_info * |
| else |
| c->mst_node->flags &= ~cpu_to_le32(UBIFS_MST_NO_ORPHS); |
| err = ubifs_write_master(c); |
| - mutex_unlock(&c->mst_mutex); |
| if (err) |
| goto out; |
| |
| --- a/fs/ubifs/master.c |
| +++ b/fs/ubifs/master.c |
| @@ -352,10 +352,9 @@ int ubifs_read_master(struct ubifs_info |
| * ubifs_write_master - write master node. |
| * @c: UBIFS file-system description object |
| * |
| - * This function writes the master node. The caller has to take the |
| - * @c->mst_mutex lock before calling this function. Returns zero in case of |
| - * success and a negative error code in case of failure. The master node is |
| - * written twice to enable recovery. |
| + * This function writes the master node. Returns zero in case of success and a |
| + * negative error code in case of failure. The master node is written twice to |
| + * enable recovery. |
| */ |
| int ubifs_write_master(struct ubifs_info *c) |
| { |
| --- a/fs/ubifs/super.c |
| +++ b/fs/ubifs/super.c |
| @@ -1970,7 +1970,6 @@ static struct ubifs_info *alloc_ubifs_in |
| mutex_init(&c->lp_mutex); |
| mutex_init(&c->tnc_mutex); |
| mutex_init(&c->log_mutex); |
| - mutex_init(&c->mst_mutex); |
| mutex_init(&c->umount_mutex); |
| mutex_init(&c->bu_mutex); |
| mutex_init(&c->write_reserve_mutex); |
| --- a/fs/ubifs/ubifs.h |
| +++ b/fs/ubifs/ubifs.h |
| @@ -1042,7 +1042,6 @@ struct ubifs_debug_info; |
| * |
| * @mst_node: master node |
| * @mst_offs: offset of valid master node |
| - * @mst_mutex: protects the master node area, @mst_node, and @mst_offs |
| * |
| * @max_bu_buf_len: maximum bulk-read buffer length |
| * @bu_mutex: protects the pre-allocated bulk-read buffer and @c->bu |
| @@ -1282,7 +1281,6 @@ struct ubifs_info { |
| |
| struct ubifs_mst_node *mst_node; |
| int mst_offs; |
| - struct mutex mst_mutex; |
| |
| int max_bu_buf_len; |
| struct mutex bu_mutex; |