| From f2e323ec96077642d397bb1c355def536d489d16 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Fri, 5 Sep 2014 09:09:28 -0300 |
| Subject: media: ttusb-dec: buffer overflow in ioctl |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit f2e323ec96077642d397bb1c355def536d489d16 upstream. |
| |
| We need to add a limit check here so we don't overflow the buffer. |
| |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/media/usb/ttusb-dec/ttusbdecfe.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/media/usb/ttusb-dec/ttusbdecfe.c |
| +++ b/drivers/media/usb/ttusb-dec/ttusbdecfe.c |
| @@ -156,6 +156,9 @@ static int ttusbdecfe_dvbs_diseqc_send_m |
| 0x00, 0x00, 0x00, 0x00, |
| 0x00, 0x00 }; |
| |
| + if (cmd->msg_len > sizeof(b) - 4) |
| + return -EINVAL; |
| + |
| memcpy(&b[4], cmd->msg, cmd->msg_len); |
| |
| state->config->send_command(fe, 0x72, |
