| From 16caf5b6101d03335b386e77e9e14136f989be87 Mon Sep 17 00:00:00 2001 |
| From: Jan Kara <jack@suse.cz> |
| Date: Thu, 23 Oct 2014 14:02:47 +0200 |
| Subject: nfs: Fix use of uninitialized variable in nfs_getattr() |
| |
| From: Jan Kara <jack@suse.cz> |
| |
| commit 16caf5b6101d03335b386e77e9e14136f989be87 upstream. |
| |
| Variable 'err' needn't be initialized when nfs_getattr() uses it to |
| check whether it should call generic_fillattr() or not. That can result |
| in spurious error returns. Initialize 'err' properly. |
| |
| Signed-off-by: Jan Kara <jack@suse.cz> |
| Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/nfs/inode.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/nfs/inode.c |
| +++ b/fs/nfs/inode.c |
| @@ -519,7 +519,7 @@ int nfs_getattr(struct vfsmount *mnt, st |
| { |
| struct inode *inode = dentry->d_inode; |
| int need_atime = NFS_I(inode)->cache_validity & NFS_INO_INVALID_ATIME; |
| - int err; |
| + int err = 0; |
| |
| /* Flush out writes to the server in order to update c/mtime. */ |
| if (S_ISREG(inode->i_mode)) { |
