| From f3d398e2465b3b74987a3a2fc42ea3e8c83d2166 Mon Sep 17 00:00:00 2001 |
| From: Jiri Benc <jbenc@redhat.com> |
| Date: Fri, 4 Oct 2013 17:04:48 +0200 |
| Subject: ipv4: fix ineffective source address selection |
| |
| From: Jiri Benc <jbenc@redhat.com> |
| |
| [ Upstream commit 0a7e22609067ff524fc7bbd45c6951dd08561667 ] |
| |
| When sending out multicast messages, the source address in inet->mc_addr is |
| ignored and rewritten by an autoselected one. This is caused by a typo in |
| commit 813b3b5db831 ("ipv4: Use caller's on-stack flowi as-is in output |
| route lookups"). |
| |
| Signed-off-by: Jiri Benc <jbenc@redhat.com> |
| Acked-by: Eric Dumazet <edumazet@google.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/ipv4/route.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/ipv4/route.c |
| +++ b/net/ipv4/route.c |
| @@ -2074,7 +2074,7 @@ struct rtable *__ip_route_output_key(str |
| RT_SCOPE_LINK); |
| goto make_route; |
| } |
| - if (fl4->saddr) { |
| + if (!fl4->saddr) { |
| if (ipv4_is_multicast(fl4->daddr)) |
| fl4->saddr = inet_select_addr(dev_out, 0, |
| fl4->flowi4_scope); |
