| From e69ccba66791d0edd0d596520de268369aaab610 Mon Sep 17 00:00:00 2001 |
| From: Mathias Krause <minipli@googlemail.com> |
| Date: Mon, 30 Sep 2013 22:05:40 +0200 |
| Subject: unix_diag: fix info leak |
| |
| From: Mathias Krause <minipli@googlemail.com> |
| |
| [ Upstream commit 6865d1e834be84ddd5808d93d5035b492346c64a ] |
| |
| When filling the netlink message we miss to wipe the pad field, |
| therefore leak one byte of heap memory to userland. Fix this by |
| setting pad to 0. |
| |
| Signed-off-by: Mathias Krause <minipli@googlemail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/unix/diag.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/net/unix/diag.c |
| +++ b/net/unix/diag.c |
| @@ -124,6 +124,7 @@ static int sk_diag_fill(struct sock *sk, |
| rep->udiag_family = AF_UNIX; |
| rep->udiag_type = sk->sk_type; |
| rep->udiag_state = sk->sk_state; |
| + rep->pad = 0; |
| rep->udiag_ino = sk_ino; |
| sock_diag_save_cookie(sk, rep->udiag_cookie); |
| |