| From 902c6a96a7cb9c50d2a8aed1788efad0a5d8f04c Mon Sep 17 00:00:00 2001 |
| From: Jesper Juhl <jj@chaosbits.net> |
| Date: Wed, 7 Mar 2012 19:09:34 +0000 |
| Subject: dm ioctl: do not leak argv if target message only contains whitespace |
| |
| From: Jesper Juhl <jj@chaosbits.net> |
| |
| commit 902c6a96a7cb9c50d2a8aed1788efad0a5d8f04c upstream. |
| |
| If 'argc' is zero we jump to the 'out:' label, but this leaks the |
| (unused) memory that 'dm_split_args()' allocated for 'argv' if the |
| string being split consisted entirely of whitespace. Jump to the |
| 'out_argv:' label instead to free up that memory. |
| |
| Signed-off-by: Jesper Juhl <jj@chaosbits.net> |
| Signed-off-by: Alasdair G Kergon <agk@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/md/dm-ioctl.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/md/dm-ioctl.c |
| +++ b/drivers/md/dm-ioctl.c |
| @@ -1437,7 +1437,7 @@ static int target_message(struct dm_ioct |
| |
| if (!argc) { |
| DMWARN("Empty message received."); |
| - goto out; |
| + goto out_argv; |
| } |
| |
| table = dm_get_live_table(md); |
