| From ea0dbebffe118724cd4df7d9b071ea8ee48d48f0 Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <jhovold@gmail.com> |
| Date: Thu, 25 Oct 2012 10:29:11 +0200 |
| Subject: USB: opticon: fix DMA from stack |
| |
| From: Johan Hovold <jhovold@gmail.com> |
| |
| commit ea0dbebffe118724cd4df7d9b071ea8ee48d48f0 upstream. |
| |
| Make sure to allocate the control-message buffer dynamically as some |
| platforms cannot do DMA from stack. |
| |
| Note that only the first byte of the old buffer was used. |
| |
| Signed-off-by: Johan Hovold <jhovold@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/serial/opticon.c | 7 ++++++- |
| 1 file changed, 6 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/usb/serial/opticon.c |
| +++ b/drivers/usb/serial/opticon.c |
| @@ -158,7 +158,11 @@ static int send_control_msg(struct usb_s |
| { |
| struct usb_serial *serial = port->serial; |
| int retval; |
| - u8 buffer[2]; |
| + u8 *buffer; |
| + |
| + buffer = kzalloc(1, GFP_KERNEL); |
| + if (!buffer) |
| + return -ENOMEM; |
| |
| buffer[0] = val; |
| /* Send the message to the vendor control endpoint |
| @@ -167,6 +171,7 @@ static int send_control_msg(struct usb_s |
| requesttype, |
| USB_DIR_OUT|USB_TYPE_VENDOR|USB_RECIP_INTERFACE, |
| 0, 0, buffer, 1, 0); |
| + kfree(buffer); |
| |
| return retval; |
| } |
