| From ea99b1adf22abd62bdcf14b1c9a0a4d3664eefd8 Mon Sep 17 00:00:00 2001 |
| From: Chen Gang <gang.chen@asianux.com> |
| Date: Thu, 30 May 2013 01:18:43 +0000 |
| Subject: parisc: kernel: using strlcpy() instead of strcpy() |
| |
| From: Chen Gang <gang.chen@asianux.com> |
| |
| commit ea99b1adf22abd62bdcf14b1c9a0a4d3664eefd8 upstream. |
| |
| 'boot_args' is an input args, and 'boot_command_line' has a fix length. |
| So use strlcpy() instead of strcpy() to avoid memory overflow. |
| |
| Signed-off-by: Chen Gang <gang.chen@asianux.com> |
| Acked-by: Kyle McMartin <kyle@mcmartin.ca> |
| Signed-off-by: Helge Deller <deller@gmx.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| arch/parisc/kernel/setup.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/arch/parisc/kernel/setup.c |
| +++ b/arch/parisc/kernel/setup.c |
| @@ -69,7 +69,8 @@ void __init setup_cmdline(char **cmdline |
| /* called from hpux boot loader */ |
| boot_command_line[0] = '\0'; |
| } else { |
| - strcpy(boot_command_line, (char *)__va(boot_args[1])); |
| + strlcpy(boot_command_line, (char *)__va(boot_args[1]), |
| + COMMAND_LINE_SIZE); |
| |
| #ifdef CONFIG_BLK_DEV_INITRD |
| if (boot_args[2] != 0) /* did palo pass us a ramdisk? */ |
