| From 95169cd23bfa88003f8be06234dbd65f5737add0 Mon Sep 17 00:00:00 2001 |
| From: Thierry Reding <treding@nvidia.com> |
| Date: Thu, 9 Jul 2015 09:59:55 +0200 |
| Subject: soc/tegra: pmc: Avoid usage of uninitialized variable |
| |
| From: Thierry Reding <treding@nvidia.com> |
| |
| commit 95169cd23bfa88003f8be06234dbd65f5737add0 upstream. |
| |
| Make sure to only drop the reference to the OF node after it's been |
| successfully obtained. |
| |
| Fixes: 3568df3d31d6 ("soc: tegra: Add thermal reset (thermtrip) support to PMC") |
| Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com> |
| Signed-off-by: Thierry Reding <treding@nvidia.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/soc/tegra/pmc.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/soc/tegra/pmc.c |
| +++ b/drivers/soc/tegra/pmc.c |
| @@ -736,12 +736,12 @@ void tegra_pmc_init_tsense_reset(struct |
| u32 value, checksum; |
| |
| if (!pmc->soc->has_tsense_reset) |
| - goto out; |
| + return; |
| |
| np = of_find_node_by_name(pmc->dev->of_node, "i2c-thermtrip"); |
| if (!np) { |
| dev_warn(dev, "i2c-thermtrip node not found, %s.\n", disabled); |
| - goto out; |
| + return; |
| } |
| |
| if (of_property_read_u32(np, "nvidia,i2c-controller-id", &ctrl_id)) { |
