| From 27892bbdc9233f33bf0f44e08aab8f12e0dec142 Mon Sep 17 00:00:00 2001 |
| From: Clint Taylor <clinton.a.taylor@intel.com> |
| Date: Wed, 18 Jan 2017 13:38:43 -0800 |
| Subject: drm/i915: prevent crash with .disable_display parameter |
| |
| From: Clint Taylor <clinton.a.taylor@intel.com> |
| |
| commit 27892bbdc9233f33bf0f44e08aab8f12e0dec142 upstream. |
| |
| The .disable_display parameter was causing a fatal crash when fbdev |
| was dereferenced during driver init. |
| |
| V1: protection in i915_drv.c |
| V2: Moved protection to intel_fbdev.c |
| |
| Fixes: 43cee314345a ("drm/i915/fbdev: Limit the global async-domain synchronization") |
| Testcase: igt/drv_module_reload/basic-no-display |
| Cc: Chris Wilson <chris@chris-wilson.co.uk> |
| Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com> |
| Link: http://patchwork.freedesktop.org/patch/msgid/1484775523-29428-1-git-send-email-clinton.a.taylor@intel.com |
| Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> |
| Cc: Lukas Wunner <lukas@wunner.de> |
| Cc: Daniel Vetter <daniel.vetter@ffwll.ch> |
| Cc: Jani Nikula <jani.nikula@linux.intel.com> |
| Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> |
| (cherry picked from commit 5b8cd0755f8a06a851c436a013e7be0823fb155a) |
| Signed-off-by: Jani Nikula <jani.nikula@intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/gpu/drm/i915/intel_fbdev.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/gpu/drm/i915/intel_fbdev.c |
| +++ b/drivers/gpu/drm/i915/intel_fbdev.c |
| @@ -745,6 +745,9 @@ void intel_fbdev_initial_config_async(st |
| { |
| struct intel_fbdev *ifbdev = to_i915(dev)->fbdev; |
| |
| + if (!ifbdev) |
| + return; |
| + |
| ifbdev->cookie = async_schedule(intel_fbdev_initial_config, ifbdev); |
| } |
| |