| From 6ebf75774f823ddbdbd10921006989d4df222f4a Mon Sep 17 00:00:00 2001 |
| From: Nicolas Iooss <nicolas.iooss_linux@m4x.org> |
| Date: Tue, 27 Dec 2016 16:02:36 -0200 |
| Subject: [media] am437x-vpfe: always assign bpp variable |
| |
| From: Nicolas Iooss <nicolas.iooss_linux@m4x.org> |
| |
| commit 6ebf75774f823ddbdbd10921006989d4df222f4a upstream. |
| |
| In vpfe_s_fmt(), when the sensor format and the requested format were |
| the same, bpp was assigned to vpfe->bpp without being initialized first. |
| |
| Grab the bpp value that is currently used by using __vpfe_get_format() |
| instead of its wrapper, vpfe_try_fmt(). |
| |
| This use of uninitialized variable has been found by compiling the |
| kernel with clang. |
| |
| Fixes: 417d2e507edc ("[media] media: platform: add VPFE capture driver |
| support for AM437X") |
| |
| Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> |
| Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/media/platform/am437x/am437x-vpfe.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/media/platform/am437x/am437x-vpfe.c |
| +++ b/drivers/media/platform/am437x/am437x-vpfe.c |
| @@ -1576,7 +1576,7 @@ static int vpfe_s_fmt(struct file *file, |
| return -EBUSY; |
| } |
| |
| - ret = vpfe_try_fmt(file, priv, &format); |
| + ret = __vpfe_get_format(vpfe, &format, &bpp); |
| if (ret) |
| return ret; |
| |
