| From f2625f7db4dd0bbd16a9c7d2950e7621f9aa57ad Mon Sep 17 00:00:00 2001 |
| From: Steve Wise <swise@opengridcomputing.com> |
| Date: Tue, 21 Feb 2017 11:21:57 -0800 |
| Subject: rdma_cm: fail iwarp accepts w/o connection params |
| |
| From: Steve Wise <swise@opengridcomputing.com> |
| |
| commit f2625f7db4dd0bbd16a9c7d2950e7621f9aa57ad upstream. |
| |
| cma_accept_iw() needs to return an error if conn_params is NULL. |
| Since this is coming from user space, we can crash. |
| |
| Reported-by: Shaobo He <shaobo@cs.utah.edu> |
| Acked-by: Sean Hefty <sean.hefty@intel.com> |
| Signed-off-by: Steve Wise <swise@opengridcomputing.com> |
| Signed-off-by: Doug Ledford <dledford@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/infiniband/core/cma.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/infiniband/core/cma.c |
| +++ b/drivers/infiniband/core/cma.c |
| @@ -3583,6 +3583,9 @@ static int cma_accept_iw(struct rdma_id_ |
| struct iw_cm_conn_param iw_param; |
| int ret; |
| |
| + if (!conn_param) |
| + return -EINVAL; |
| + |
| ret = cma_modify_qp_rtr(id_priv, conn_param); |
| if (ret) |
| return ret; |