| From dc01a28d80a42cef08c94dfc595565aaebe46d15 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Fri, 15 Jul 2016 14:06:30 +0300 |
| Subject: mtd: maps: sa1100-flash: potential NULL dereference |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit dc01a28d80a42cef08c94dfc595565aaebe46d15 upstream. |
| |
| We check for NULL but then dereference "info->mtd" on the next line. |
| |
| Fixes: 72169755cf36 ('mtd: maps: sa1100-flash: show parent device in sysfs') |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Brian Norris <computersforpeace@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/mtd/maps/sa1100-flash.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/mtd/maps/sa1100-flash.c |
| +++ b/drivers/mtd/maps/sa1100-flash.c |
| @@ -230,8 +230,10 @@ static struct sa_info *sa1100_setup_mtd( |
| |
| info->mtd = mtd_concat_create(cdev, info->num_subdev, |
| plat->name); |
| - if (info->mtd == NULL) |
| + if (info->mtd == NULL) { |
| ret = -ENXIO; |
| + goto err; |
| + } |
| } |
| info->mtd->dev.parent = &pdev->dev; |
| |
