| From 603616017c35f4d0fbdbcace72adf9bf949c4a65 Mon Sep 17 00:00:00 2001 |
| From: Hoan Tran <hotran@apm.com> |
| Date: Mon, 10 Oct 2016 10:13:10 -0700 |
| Subject: i2c: xgene: Avoid dma_buffer overrun |
| |
| From: Hoan Tran <hotran@apm.com> |
| |
| commit 603616017c35f4d0fbdbcace72adf9bf949c4a65 upstream. |
| |
| SMBus block command uses the first byte of buffer for the data length. |
| The dma_buffer should be increased by 1 to avoid the overrun issue. |
| |
| Reported-by: Phil Endecott <phil_gjouf_endecott@chezphil.org> |
| Signed-off-by: Hoan Tran <hotran@apm.com> |
| Signed-off-by: Wolfram Sang <wsa@the-dreams.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/i2c/busses/i2c-xgene-slimpro.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/i2c/busses/i2c-xgene-slimpro.c |
| +++ b/drivers/i2c/busses/i2c-xgene-slimpro.c |
| @@ -105,7 +105,7 @@ struct slimpro_i2c_dev { |
| struct mbox_chan *mbox_chan; |
| struct mbox_client mbox_client; |
| struct completion rd_complete; |
| - u8 dma_buffer[I2C_SMBUS_BLOCK_MAX]; |
| + u8 dma_buffer[I2C_SMBUS_BLOCK_MAX + 1]; /* dma_buffer[0] is used for length */ |
| u32 *resp_msg; |
| }; |
| |
