| From 68e0010c1df71e51a6ddcff934f51f2b3d65b6f0 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 17 Mar 2021 17:28:58 +0530 |
| Subject: libbpf: Use SOCK_CLOEXEC when opening the netlink socket |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Kumar Kartikeya Dwivedi <memxor@gmail.com> |
| |
| [ Upstream commit 58bfd95b554f1a23d01228672f86bb489bdbf4ba ] |
| |
| Otherwise, there exists a small window between the opening and closing |
| of the socket fd where it may leak into processes launched by some other |
| thread. |
| |
| Fixes: 949abbe88436 ("libbpf: add function to setup XDP") |
| Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com> |
| Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> |
| Acked-by: Toke Høiland-Jørgensen <toke@redhat.com> |
| Link: https://lore.kernel.org/bpf/20210317115857.6536-1-memxor@gmail.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/lib/bpf/netlink.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/tools/lib/bpf/netlink.c b/tools/lib/bpf/netlink.c |
| index 88416be2bf99..5ec8043c71bc 100644 |
| --- a/tools/lib/bpf/netlink.c |
| +++ b/tools/lib/bpf/netlink.c |
| @@ -37,7 +37,7 @@ int libbpf_netlink_open(__u32 *nl_pid) |
| memset(&sa, 0, sizeof(sa)); |
| sa.nl_family = AF_NETLINK; |
| |
| - sock = socket(AF_NETLINK, SOCK_RAW, NETLINK_ROUTE); |
| + sock = socket(AF_NETLINK, SOCK_RAW | SOCK_CLOEXEC, NETLINK_ROUTE); |
| if (sock < 0) |
| return -errno; |
| |
| -- |
| 2.30.1 |
| |
