| From 21ab661ad33ae05f822638295c6b6e2b57e72fc8 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 17 May 2022 17:42:31 +0800 |
| Subject: net: af_key: add check for pfkey_broadcast in function pfkey_process |
| |
| From: Jiasheng Jiang <jiasheng@iscas.ac.cn> |
| |
| [ Upstream commit 4dc2a5a8f6754492180741facf2a8787f2c415d7 ] |
| |
| If skb_clone() returns null pointer, pfkey_broadcast() will |
| return error. |
| Therefore, it should be better to check the return value of |
| pfkey_broadcast() and return error if fails. |
| |
| Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") |
| Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> |
| Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/key/af_key.c | 6 ++++-- |
| 1 file changed, 4 insertions(+), 2 deletions(-) |
| |
| diff --git a/net/key/af_key.c b/net/key/af_key.c |
| index a416c0f90056..170960ef7e36 100644 |
| --- a/net/key/af_key.c |
| +++ b/net/key/af_key.c |
| @@ -2836,8 +2836,10 @@ static int pfkey_process(struct sock *sk, struct sk_buff *skb, const struct sadb |
| void *ext_hdrs[SADB_EXT_MAX]; |
| int err; |
| |
| - pfkey_broadcast(skb_clone(skb, GFP_KERNEL), GFP_KERNEL, |
| - BROADCAST_PROMISC_ONLY, NULL, sock_net(sk)); |
| + err = pfkey_broadcast(skb_clone(skb, GFP_KERNEL), GFP_KERNEL, |
| + BROADCAST_PROMISC_ONLY, NULL, sock_net(sk)); |
| + if (err) |
| + return err; |
| |
| memset(ext_hdrs, 0, sizeof(ext_hdrs)); |
| err = parse_exthdrs(skb, hdr, ext_hdrs); |
| -- |
| 2.35.1 |
| |
