| From 0ab8b705dfb268e57f99d90da0152168f9d9558e Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 2 Jul 2021 22:21:40 +0800 |
| Subject: regulator: mtk-dvfsrc: Fix wrong dev pointer for |
| devm_regulator_register |
| |
| From: Axel Lin <axel.lin@ingics.com> |
| |
| [ Upstream commit ea986908ccfcc53204a03bb0841227e1b26578c4 ] |
| |
| If use dev->parent, the regulator_unregister will not be called when this |
| driver is unloaded. Fix it by using dev instead. |
| |
| Signed-off-by: Axel Lin <axel.lin@ingics.com> |
| Link: https://lore.kernel.org/r/20210702142140.2678130-1-axel.lin@ingics.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/regulator/mtk-dvfsrc-regulator.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| diff --git a/drivers/regulator/mtk-dvfsrc-regulator.c b/drivers/regulator/mtk-dvfsrc-regulator.c |
| index d3d876198d6e..234af3a66c77 100644 |
| --- a/drivers/regulator/mtk-dvfsrc-regulator.c |
| +++ b/drivers/regulator/mtk-dvfsrc-regulator.c |
| @@ -179,8 +179,7 @@ static int dvfsrc_vcore_regulator_probe(struct platform_device *pdev) |
| for (i = 0; i < regulator_init_data->size; i++) { |
| config.dev = dev->parent; |
| config.driver_data = (mt_regulators + i); |
| - rdev = devm_regulator_register(dev->parent, |
| - &(mt_regulators + i)->desc, |
| + rdev = devm_regulator_register(dev, &(mt_regulators + i)->desc, |
| &config); |
| if (IS_ERR(rdev)) { |
| dev_err(dev, "failed to register %s\n", |
| -- |
| 2.30.2 |
| |
