| From 15f03ffe4bb951e982457f44b6cf6b06ef4cbb93 Mon Sep 17 00:00:00 2001 |
| From: Fabio Estevam <festevam@denx.de> |
| Date: Wed, 4 May 2022 11:31:04 -0300 |
| Subject: net: phy: micrel: Pass .probe for KS8737 |
| |
| From: Fabio Estevam <festevam@denx.de> |
| |
| commit 15f03ffe4bb951e982457f44b6cf6b06ef4cbb93 upstream. |
| |
| Since commit f1131b9c23fb ("net: phy: micrel: use |
| kszphy_suspend()/kszphy_resume for irq aware devices") the kszphy_suspend/ |
| resume hooks are used. |
| |
| These functions require the probe function to be called so that |
| priv can be allocated. |
| |
| Otherwise, a NULL pointer dereference happens inside |
| kszphy_config_reset(). |
| |
| Cc: stable@vger.kernel.org |
| Fixes: f1131b9c23fb ("net: phy: micrel: use kszphy_suspend()/kszphy_resume for irq aware devices") |
| Reported-by: Andrew Lunn <andrew@lunn.ch> |
| Signed-off-by: Fabio Estevam <festevam@denx.de> |
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> |
| Link: https://lore.kernel.org/r/20220504143104.1286960-2-festevam@gmail.com |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/phy/micrel.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/net/phy/micrel.c |
| +++ b/drivers/net/phy/micrel.c |
| @@ -1725,6 +1725,7 @@ static struct phy_driver ksphy_driver[] |
| .name = "Micrel KS8737", |
| /* PHY_BASIC_FEATURES */ |
| .driver_data = &ks8737_type, |
| + .probe = kszphy_probe, |
| .config_init = kszphy_config_init, |
| .config_intr = kszphy_config_intr, |
| .handle_interrupt = kszphy_handle_interrupt, |