| From 74eb6283225e84881e62678e78c5e69753ffc05d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 10 May 2022 09:05:08 +0200 |
| Subject: s390/lcs: fix variable dereferenced before check |
| |
| From: Alexandra Winter <wintera@linux.ibm.com> |
| |
| [ Upstream commit 671bb35c8e746439f0ed70815968f9a4f20a8deb ] |
| |
| smatch complains about |
| drivers/s390/net/lcs.c:1741 lcs_get_control() warn: variable dereferenced before check 'card->dev' (see line 1739) |
| |
| Fixes: 27eb5ac8f015 ("[PATCH] s390: lcs driver bug fixes and improvements [1/2]") |
| Signed-off-by: Alexandra Winter <wintera@linux.ibm.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/s390/net/lcs.c | 7 ++++--- |
| 1 file changed, 4 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/s390/net/lcs.c b/drivers/s390/net/lcs.c |
| index 251db0a02e73..4d3caad7e981 100644 |
| --- a/drivers/s390/net/lcs.c |
| +++ b/drivers/s390/net/lcs.c |
| @@ -1761,10 +1761,11 @@ lcs_get_control(struct lcs_card *card, struct lcs_cmd *cmd) |
| lcs_schedule_recovery(card); |
| break; |
| case LCS_CMD_STOPLAN: |
| - pr_warn("Stoplan for %s initiated by LGW\n", |
| - card->dev->name); |
| - if (card->dev) |
| + if (card->dev) { |
| + pr_warn("Stoplan for %s initiated by LGW\n", |
| + card->dev->name); |
| netif_carrier_off(card->dev); |
| + } |
| break; |
| default: |
| LCS_DBF_TEXT(5, trace, "noLGWcmd"); |
| -- |
| 2.35.1 |
| |