| From 55dc632ab2ac2889b15995a9eef56c753d48ebc7 Mon Sep 17 00:00:00 2001 |
| From: Ian Ray <ian.ray@gehealthcare.com> |
| Date: Tue, 17 Mar 2026 10:53:36 +0200 |
| Subject: NFC: nxp-nci: allow GPIOs to sleep |
| |
| From: Ian Ray <ian.ray@gehealthcare.com> |
| |
| commit 55dc632ab2ac2889b15995a9eef56c753d48ebc7 upstream. |
| |
| Allow the firmware and enable GPIOs to sleep. |
| |
| This fixes a `WARN_ON' and allows the driver to operate GPIOs which are |
| connected to I2C GPIO expanders. |
| |
| -- >8 -- |
| kernel: WARNING: CPU: 3 PID: 2636 at drivers/gpio/gpiolib.c:3880 gpiod_set_value+0x88/0x98 |
| -- >8 -- |
| |
| Fixes: 43201767b44c ("NFC: nxp-nci: Convert to use GPIO descriptor") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Ian Ray <ian.ray@gehealthcare.com> |
| Link: https://patch.msgid.link/20260317085337.146545-1-ian.ray@gehealthcare.com |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/nfc/nxp-nci/i2c.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/nfc/nxp-nci/i2c.c |
| +++ b/drivers/nfc/nxp-nci/i2c.c |
| @@ -47,8 +47,8 @@ static int nxp_nci_i2c_set_mode(void *ph |
| { |
| struct nxp_nci_i2c_phy *phy = (struct nxp_nci_i2c_phy *) phy_id; |
| |
| - gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); |
| - gpiod_set_value(phy->gpiod_en, (mode != NXP_NCI_MODE_COLD) ? 1 : 0); |
| + gpiod_set_value_cansleep(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); |
| + gpiod_set_value_cansleep(phy->gpiod_en, (mode != NXP_NCI_MODE_COLD) ? 1 : 0); |
| usleep_range(10000, 15000); |
| |
| if (mode == NXP_NCI_MODE_COLD) |
