| From stable-bounces@linux.kernel.org Sat Nov 5 10:41:13 2005 |
| Date: Tue, 1 Nov 2005 15:26:45 -0800 |
| From: Stephen Hemminger <shemminger@osdl.org> |
| To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>, "David S. Miller" <davem@davemloft.net> |
| Message-ID: <20051101152645.31075d19@dxpl.pdx.osdl.net> |
| Cc: netdev@vger.kernel.org |
| Subject: tcp: BIC max increment too large |
| |
| The max growth of BIC TCP is too large. Original code was based on |
| BIC 1.0 and the default there was 32. Later code (2.6.13) included |
| compensation for delayed acks, and should have reduced the default |
| value to 16; since normally TCP gets one ack for every two packets sent. |
| |
| The current value of 32 makes BIC too aggressive and unfair to other |
| flows. |
| |
| Submitted-by: Injong Rhee <rhee@eos.ncsu.edu> |
| Signed-off-by: Stephen Hemminger <shemminger@osdl.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| net/ipv4/tcp_bic.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- linux-2.6.14.1.orig/net/ipv4/tcp_bic.c |
| +++ linux-2.6.14.1/net/ipv4/tcp_bic.c |
| @@ -27,7 +27,7 @@ |
| */ |
| |
| static int fast_convergence = 1; |
| -static int max_increment = 32; |
| +static int max_increment = 16; |
| static int low_window = 14; |
| static int beta = 819; /* = 819/1024 (BICTCP_BETA_SCALE) */ |
| static int low_utilization_threshold = 153; |
