| From foo@baz Sat Sep 26 11:20:32 PDT 2015 |
| From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> |
| Date: Mon, 13 Jul 2015 06:36:19 -0700 |
| Subject: bridge: mdb: fix double add notification |
| |
| From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> |
| |
| [ Upstream commit 5ebc784625ea68a9570d1f70557e7932988cd1b4 ] |
| |
| Since the mdb add/del code was introduced there have been 2 br_mdb_notify |
| calls when doing br_mdb_add() resulting in 2 notifications on each add. |
| |
| Example: |
| Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent |
| Before patch: |
| root@debian:~# bridge monitor all |
| [MDB]dev br0 port eth1 grp 239.0.0.1 permanent |
| [MDB]dev br0 port eth1 grp 239.0.0.1 permanent |
| |
| After patch: |
| root@debian:~# bridge monitor all |
| [MDB]dev br0 port eth1 grp 239.0.0.1 permanent |
| |
| Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> |
| Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries") |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/bridge/br_mdb.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/net/bridge/br_mdb.c |
| +++ b/net/bridge/br_mdb.c |
| @@ -345,7 +345,6 @@ static int br_mdb_add_group(struct net_b |
| return -ENOMEM; |
| rcu_assign_pointer(*pp, p); |
| |
| - br_mdb_notify(br->dev, port, group, RTM_NEWMDB); |
| return 0; |
| } |
| |
