| From c5e691928bf166ac03430e957038b60adba3cf6c Mon Sep 17 00:00:00 2001 |
| From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> |
| Date: Tue, 24 Mar 2015 09:57:55 -0400 |
| Subject: tools lib traceevent kbuffer: Remove extra update to data pointer in PADDING |
| |
| From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> |
| |
| commit c5e691928bf166ac03430e957038b60adba3cf6c upstream. |
| |
| When a event PADDING is hit (a deleted event that is still in the ring |
| buffer), translate_data() sets the length of the padding and also updates |
| the data pointer which is passed back to the caller. |
| |
| This is unneeded because the caller also updates the data pointer with |
| the passed back length. translate_data() should not update the pointer, |
| only set the length. |
| |
| Signed-off-by: Steven Rostedt <rostedt@goodmis.org> |
| Cc: Andrew Morton <akpm@linux-foundation.org> |
| Cc: Jiri Olsa <jolsa@redhat.com> |
| Cc: Namhyung Kim <namhyung@kernel.org> |
| Link: http://lkml.kernel.org/r/20150324135923.461431960@goodmis.org |
| Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| tools/lib/traceevent/kbuffer-parse.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/tools/lib/traceevent/kbuffer-parse.c |
| +++ b/tools/lib/traceevent/kbuffer-parse.c |
| @@ -372,7 +372,6 @@ translate_data(struct kbuffer *kbuf, voi |
| switch (type_len) { |
| case KBUFFER_TYPE_PADDING: |
| *length = read_4(kbuf, data); |
| - data += *length; |
| break; |
| |
| case KBUFFER_TYPE_TIME_EXTEND: |
