| From b7c747d4627462f25b3daabf49c18895a6722faa Mon Sep 17 00:00:00 2001 |
| From: Alexandre TORGUE <alexandre.torgue@st.com> |
| Date: Tue, 30 May 2017 16:43:04 +0200 |
| Subject: pinctrl: stm32: Fix bad function call |
| |
| From: Alexandre TORGUE <alexandre.torgue@st.com> |
| |
| commit b7c747d4627462f25b3daabf49c18895a6722faa upstream. |
| |
| In stm32_pconf_parse_conf function, stm32_pmx_gpio_set_direction is |
| called with wrong parameter value. Indeed, using NULL value for range |
| will raise an oops. |
| |
| Fixes: aceb16dc2da5 ("pinctrl: Add STM32 MCUs support") |
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com> |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/pinctrl/stm32/pinctrl-stm32.c |
| +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c |
| @@ -786,7 +786,7 @@ static int stm32_pconf_parse_conf(struct |
| break; |
| case PIN_CONFIG_OUTPUT: |
| __stm32_gpio_set(bank, offset, arg); |
| - ret = stm32_pmx_gpio_set_direction(pctldev, NULL, pin, false); |
| + ret = stm32_pmx_gpio_set_direction(pctldev, range, pin, false); |
| break; |
| default: |
| ret = -EINVAL; |
