| From 04fb365c453e14ff9e8a28f1c46050d920a27a4a Mon Sep 17 00:00:00 2001 |
| From: Felipe Balbi <felipe.balbi@linux.intel.com> |
| Date: Wed, 17 May 2017 15:57:45 +0300 |
| Subject: usb: dwc3: replace %p with %pK |
| |
| From: Felipe Balbi <felipe.balbi@linux.intel.com> |
| |
| commit 04fb365c453e14ff9e8a28f1c46050d920a27a4a upstream. |
| |
| %p will leak kernel pointers, so let's not expose the information on |
| dmesg and instead use %pK. %pK will only show the actual addresses if |
| explicitly enabled under /proc/sys/kernel/kptr_restrict. |
| |
| Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/dwc3/dwc3-st.c | 2 +- |
| drivers/usb/dwc3/gadget.c | 9 +++------ |
| 2 files changed, 4 insertions(+), 7 deletions(-) |
| |
| --- a/drivers/usb/dwc3/dwc3-st.c |
| +++ b/drivers/usb/dwc3/dwc3-st.c |
| @@ -230,7 +230,7 @@ static int st_dwc3_probe(struct platform |
| |
| dwc3_data->syscfg_reg_off = res->start; |
| |
| - dev_vdbg(&pdev->dev, "glue-logic addr 0x%p, syscfg-reg offset 0x%x\n", |
| + dev_vdbg(&pdev->dev, "glue-logic addr 0x%pK, syscfg-reg offset 0x%x\n", |
| dwc3_data->glue_base, dwc3_data->syscfg_reg_off); |
| |
| dwc3_data->rstc_pwrdn = |
| --- a/drivers/usb/dwc3/gadget.c |
| +++ b/drivers/usb/dwc3/gadget.c |
| @@ -1212,12 +1212,9 @@ static int __dwc3_gadget_ep_queue(struct |
| return -ESHUTDOWN; |
| } |
| |
| - if (WARN(req->dep != dep, "request %p belongs to '%s'\n", |
| - &req->request, req->dep->name)) { |
| - dev_err(dwc->dev, "%s: request %p belongs to '%s'\n", |
| - dep->name, &req->request, req->dep->name); |
| + if (WARN(req->dep != dep, "request %pK belongs to '%s'\n", |
| + &req->request, req->dep->name)) |
| return -EINVAL; |
| - } |
| |
| pm_runtime_get(dwc->dev); |
| |
| @@ -1429,7 +1426,7 @@ static int dwc3_gadget_ep_dequeue(struct |
| } |
| goto out1; |
| } |
| - dev_err(dwc->dev, "request %p was not queued to %s\n", |
| + dev_err(dwc->dev, "request %pK was not queued to %s\n", |
| request, ep->name); |
| ret = -EINVAL; |
| goto out0; |