| From 3d96e6902d2900fb38bdfaa4e7c53a635c0ca793 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 27 Aug 2021 18:32:50 +0200 |
| Subject: cryptoloop: add a deprecation warning |
| |
| From: Christoph Hellwig <hch@lst.de> |
| |
| [ Upstream commit 222013f9ac30b9cec44301daa8dbd0aae38abffb ] |
| |
| Support for cryptoloop has been officially marked broken and deprecated |
| in favor of dm-crypt (which supports the same broken algorithms if |
| needed) in Linux 2.6.4 (released in March 2004), and support for it has |
| been entirely removed from losetup in util-linux 2.23 (released in April |
| 2013). Add a warning and a deprecation schedule. |
| |
| Signed-off-by: Christoph Hellwig <hch@lst.de> |
| Link: https://lore.kernel.org/r/20210827163250.255325-1-hch@lst.de |
| Signed-off-by: Jens Axboe <axboe@kernel.dk> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/block/Kconfig | 4 ++-- |
| drivers/block/cryptoloop.c | 2 ++ |
| 2 files changed, 4 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig |
| index 01091c08e999..ef702fdb2f92 100644 |
| --- a/drivers/block/Kconfig |
| +++ b/drivers/block/Kconfig |
| @@ -234,7 +234,7 @@ config BLK_DEV_LOOP_MIN_COUNT |
| dynamically allocated with the /dev/loop-control interface. |
| |
| config BLK_DEV_CRYPTOLOOP |
| - tristate "Cryptoloop Support" |
| + tristate "Cryptoloop Support (DEPRECATED)" |
| select CRYPTO |
| select CRYPTO_CBC |
| depends on BLK_DEV_LOOP |
| @@ -246,7 +246,7 @@ config BLK_DEV_CRYPTOLOOP |
| WARNING: This device is not safe for journaled file systems like |
| ext3 or Reiserfs. Please use the Device Mapper crypto module |
| instead, which can be configured to be on-disk compatible with the |
| - cryptoloop device. |
| + cryptoloop device. cryptoloop support will be removed in Linux 5.16. |
| |
| source "drivers/block/drbd/Kconfig" |
| |
| diff --git a/drivers/block/cryptoloop.c b/drivers/block/cryptoloop.c |
| index 74e03aa537ad..32363816cb04 100644 |
| --- a/drivers/block/cryptoloop.c |
| +++ b/drivers/block/cryptoloop.c |
| @@ -203,6 +203,8 @@ init_cryptoloop(void) |
| |
| if (rc) |
| printk(KERN_ERR "cryptoloop: loop_register_transfer failed\n"); |
| + else |
| + pr_warn("the cryptoloop driver has been deprecated and will be removed in in Linux 5.16\n"); |
| return rc; |
| } |
| |
| -- |
| 2.30.2 |
| |
