| From ca943d061ff6ffe2309241ed065faee1ef61d93e Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 3 Sep 2021 14:42:33 +0800 |
| Subject: ethtool: Fix an error code in cxgb2.c |
| |
| From: Yang Li <yang.lee@linux.alibaba.com> |
| |
| [ Upstream commit 7db8263a12155c7ae4ad97e850f1e499c73765fc ] |
| |
| When adapter->registered_device_map is NULL, the value of err is |
| uncertain, we set err to -EINVAL to avoid ambiguity. |
| |
| Clean up smatch warning: |
| drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing |
| error code 'err' |
| |
| Reported-by: Abaci Robot <abaci@linux.alibaba.com> |
| Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c |
| index 8623be13bf86..eef8fa100889 100644 |
| --- a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c |
| +++ b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c |
| @@ -1157,6 +1157,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) |
| if (!adapter->registered_device_map) { |
| pr_err("%s: could not register any net devices\n", |
| pci_name(pdev)); |
| + err = -EINVAL; |
| goto out_release_adapter_res; |
| } |
| |
| -- |
| 2.30.2 |
| |
