| From 03f34b6f9101d89d3e0c4c9cb81ca952d2d25332 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 30 Jul 2021 11:07:10 +0100 |
| Subject: parport: remove non-zero check on count |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| [ Upstream commit 0be883a0d795d9146f5325de582584147dd0dcdc ] |
| |
| The check for count appears to be incorrect since a non-zero count |
| check occurs a couple of statements earlier. Currently the check is |
| always false and the dev->port->irq != PARPORT_IRQ_NONE part of the |
| check is never tested and the if statement is dead-code. Fix this |
| by removing the check on count. |
| |
| Note that this code is pre-git history, so I can't find a sha for |
| it. |
| |
| Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Addresses-Coverity: ("Logically dead code") |
| Link: https://lore.kernel.org/r/20210730100710.27405-1-colin.king@canonical.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/parport/ieee1284_ops.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/parport/ieee1284_ops.c b/drivers/parport/ieee1284_ops.c |
| index 5d41dda6da4e..75daa16f38b7 100644 |
| --- a/drivers/parport/ieee1284_ops.c |
| +++ b/drivers/parport/ieee1284_ops.c |
| @@ -535,7 +535,7 @@ size_t parport_ieee1284_ecp_read_data (struct parport *port, |
| goto out; |
| |
| /* Yield the port for a while. */ |
| - if (count && dev->port->irq != PARPORT_IRQ_NONE) { |
| + if (dev->port->irq != PARPORT_IRQ_NONE) { |
| parport_release (dev); |
| schedule_timeout_interruptible(msecs_to_jiffies(40)); |
| parport_claim_or_block (dev); |
| -- |
| 2.30.2 |
| |
