| From 1c833bd6bcab52ef2440777415fb260578f76658 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 6 Jan 2023 08:59:51 +0800 |
| Subject: thermal: intel: Fix unsigned comparison with less than zero |
| |
| From: Yang Li <yang.lee@linux.alibaba.com> |
| |
| [ Upstream commit e7fcfe67f9f410736b758969477b17ea285e8e6c ] |
| |
| The return value from the call to intel_tcc_get_tjmax() is int, which can |
| be a negative error code. However, the return value is being assigned to |
| an u32 variable 'tj_max', so making 'tj_max' an int. |
| |
| Eliminate the following warning: |
| ./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING: Unsigned expression compared with zero: tj_max < 0 |
| |
| Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637 |
| Reported-by: Abaci Robot <abaci@linux.alibaba.com> |
| Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> |
| Acked-by: Zhang Rui <rui.zhang@intel.com> |
| Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/thermal/intel_soc_dts_iosf.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/thermal/intel_soc_dts_iosf.c b/drivers/thermal/intel_soc_dts_iosf.c |
| index e0813dfaa2783..435a093998000 100644 |
| --- a/drivers/thermal/intel_soc_dts_iosf.c |
| +++ b/drivers/thermal/intel_soc_dts_iosf.c |
| @@ -405,7 +405,7 @@ struct intel_soc_dts_sensors *intel_soc_dts_iosf_init( |
| { |
| struct intel_soc_dts_sensors *sensors; |
| bool notification; |
| - u32 tj_max; |
| + int tj_max; |
| int ret; |
| int i; |
| |
| -- |
| 2.39.2 |
| |
