| From a49a83ab05e34edd6c71a4fbd062c9a7ba6d18aa Mon Sep 17 00:00:00 2001 |
| From: Takashi Sakamoto <o-takashi@sakamocchi.jp> |
| Date: Thu, 13 Sep 2018 21:30:34 +0900 |
| Subject: ALSA: firewire-digi00x: fix memory leak of private data |
| |
| From: Takashi Sakamoto <o-takashi@sakamocchi.jp> |
| |
| commit a49a83ab05e34edd6c71a4fbd062c9a7ba6d18aa upstream. |
| |
| Although private data of sound card instance is usually allocated in the |
| tail of the instance, drivers in ALSA firewire stack allocate the private |
| data before allocating the instance. In this case, the private data |
| should be released explicitly at .private_free callback of the instance. |
| |
| This commit fixes memory leak following to the above design. |
| |
| Fixes: 86c8dd7f4da3 ('ALSA: firewire-digi00x: delayed registration of sound card') |
| Cc: <stable@vger.kernel.org> # v4.7+ |
| Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/firewire/digi00x/digi00x.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/sound/firewire/digi00x/digi00x.c |
| +++ b/sound/firewire/digi00x/digi00x.c |
| @@ -49,6 +49,7 @@ static void dg00x_free(struct snd_dg00x |
| fw_unit_put(dg00x->unit); |
| |
| mutex_destroy(&dg00x->mutex); |
| + kfree(dg00x); |
| } |
| |
| static void dg00x_card_free(struct snd_card *card) |
