| From 19a4fbffc94e41abaa2a623a25ce2641d69eccf0 Mon Sep 17 00:00:00 2001 |
| From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> |
| Date: Thu, 13 Sep 2018 15:37:04 +0200 |
| Subject: gpiolib: Free the last requested descriptor |
| |
| From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> |
| |
| commit 19a4fbffc94e41abaa2a623a25ce2641d69eccf0 upstream. |
| |
| The current code only frees N-1 gpios if an error occurs during |
| gpiod_set_transitory, gpiod_direction_output or gpiod_direction_input. |
| Leading to gpios that cannot be used by userspace nor other drivers. |
| |
| Cc: Timur Tabi <timur@codeaurora.org> |
| Cc: stable@vger.kernel.org |
| Fixes: ab3dbcf78f60f46d ("gpioib: do not free unrequested descriptors) |
| Reported-by: Jan Lorenzen <jl@newtec.dk> |
| Reported-by: Jim Paris <jim@jtan.com> |
| Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/gpio/gpiolib.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/gpio/gpiolib.c |
| +++ b/drivers/gpio/gpiolib.c |
| @@ -489,7 +489,7 @@ static int linehandle_create(struct gpio |
| if (ret) |
| goto out_free_descs; |
| lh->descs[i] = desc; |
| - count = i; |
| + count = i + 1; |
| |
| if (lflags & GPIOHANDLE_REQUEST_ACTIVE_LOW) |
| set_bit(FLAG_ACTIVE_LOW, &desc->flags); |
