| From foo@baz Wed Aug 22 09:16:55 CEST 2018 |
| From: Maciej Purski <m.purski@samsung.com> |
| Date: Wed, 22 Nov 2017 10:08:38 +0100 |
| Subject: drm/bridge/sii8620: fix potential buffer overflow |
| |
| From: Maciej Purski <m.purski@samsung.com> |
| |
| [ Upstream commit 9378cecb1ce5d618b8aff4d65113ddcf72fc1011 ] |
| |
| Buffer overflow error should not occur, as mode_fixup() callback |
| filters pixel clock value and it should never exceed 600000. However, |
| current implementation is not obviously safe and relies on |
| implementation of mode_fixup(). |
| |
| Make 'i' variable never reach unsafe value in order to avoid buffer |
| overflow error. |
| |
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Fixes: bf1722ca ("drm/bridge/sii8620: rewrite hdmi start sequence") |
| Signed-off-by: Maciej Purski <m.purski@samsung.com> |
| Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/1511341718-6974-1-git-send-email-m.purski@samsung.com |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/gpu/drm/bridge/sil-sii8620.c |
| +++ b/drivers/gpu/drm/bridge/sil-sii8620.c |
| @@ -1228,7 +1228,7 @@ static void sii8620_start_video(struct s |
| int clk = ctx->pixel_clock * (ctx->use_packed_pixel ? 2 : 3); |
| int i; |
| |
| - for (i = 0; i < ARRAY_SIZE(clk_spec); ++i) |
| + for (i = 0; i < ARRAY_SIZE(clk_spec) - 1; ++i) |
| if (clk < clk_spec[i].max_clk) |
| break; |
| |
