| From e1c484f2c6b0bd8e7ebe285d89964c9b86ff184c Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 20 Feb 2022 12:17:45 +0900 |
| Subject: scsi: pm8001: Fix command initialization in pm8001_chip_ssp_tm_req() |
| |
| From: Damien Le Moal <damien.lemoal@opensource.wdc.com> |
| |
| [ Upstream commit cd2268a180117aa8ebb23e090ba204324b2d0e93 ] |
| |
| The ds_ads_m field of struct ssp_ini_tm_start_req has the type __le32. |
| Assigning a value to it should thus use cpu_to_le32(). This fixes the |
| sparse warning: |
| |
| warning: incorrect type in assignment (different base types) |
| expected restricted __le32 [addressable] [assigned] [usertype] ds_ads_m |
| got int |
| |
| Link: https://lore.kernel.org/r/20220220031810.738362-7-damien.lemoal@opensource.wdc.com |
| Fixes: dbf9bfe61571 ("[SCSI] pm8001: add SAS/SATA HBA driver") |
| Reviewed-by: Jack Wang <jinpu.wang@ionos.com> |
| Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/pm8001/pm8001_hwi.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c |
| index d0f3b65224f5..6c54500237cd 100644 |
| --- a/drivers/scsi/pm8001/pm8001_hwi.c |
| +++ b/drivers/scsi/pm8001/pm8001_hwi.c |
| @@ -4727,7 +4727,7 @@ int pm8001_chip_ssp_tm_req(struct pm8001_hba_info *pm8001_ha, |
| memcpy(sspTMCmd.lun, task->ssp_task.LUN, 8); |
| sspTMCmd.tag = cpu_to_le32(ccb->ccb_tag); |
| if (pm8001_ha->chip_id != chip_8001) |
| - sspTMCmd.ds_ads_m = 0x08; |
| + sspTMCmd.ds_ads_m = cpu_to_le32(0x08); |
| circularQ = &pm8001_ha->inbnd_q_tbl[0]; |
| ret = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &sspTMCmd, 0); |
| return ret; |
| -- |
| 2.34.1 |
| |
