| From ff7ca05665e39a84c7306cae1a1363b4a9dbdda6 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 19 Jan 2023 15:12:55 -0800 |
| Subject: drm/mediatek: Drop unbalanced obj unref |
| |
| From: Rob Clark <robdclark@chromium.org> |
| |
| [ Upstream commit 4deef811828e87e26a978d5d6433b261d4713849 ] |
| |
| In the error path, mtk_drm_gem_object_mmap() is dropping an obj |
| reference that it doesn't own. |
| |
| Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") |
| Signed-off-by: Rob Clark <robdclark@chromium.org> |
| Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20230119231255.2883365-1-robdclark@gmail.com/ |
| Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c |
| index 259b7b0de1d22..b09a37a38e0ae 100644 |
| --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c |
| +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c |
| @@ -148,8 +148,6 @@ static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj, |
| |
| ret = dma_mmap_attrs(priv->dma_dev, vma, mtk_gem->cookie, |
| mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs); |
| - if (ret) |
| - drm_gem_vm_close(vma); |
| |
| return ret; |
| } |
| -- |
| 2.39.2 |
| |
