| From 1a08bb81d6789a2a1e07f0b0d7bd8e4bc6f2ff37 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 3 Feb 2023 15:27:14 +0200 |
| Subject: pinctrl: at91: use devm_kasprintf() to avoid potential leaks |
| |
| From: Claudiu Beznea <claudiu.beznea@microchip.com> |
| |
| [ Upstream commit 1c4e5c470a56f7f7c649c0c70e603abc1eab15c4 ] |
| |
| Use devm_kasprintf() instead of kasprintf() to avoid any potential |
| leaks. At the moment drivers have no remove functionality thus |
| there is no need for fixes tag. |
| |
| Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> |
| Link: https://lore.kernel.org/r/20230203132714.1931596-1-claudiu.beznea@microchip.com |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pinctrl/pinctrl-at91-pio4.c | 4 ++-- |
| drivers/pinctrl/pinctrl-at91.c | 2 +- |
| 2 files changed, 3 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c |
| index 9e2f3738bf3ec..89d88e447d44f 100644 |
| --- a/drivers/pinctrl/pinctrl-at91-pio4.c |
| +++ b/drivers/pinctrl/pinctrl-at91-pio4.c |
| @@ -1022,8 +1022,8 @@ static int atmel_pinctrl_probe(struct platform_device *pdev) |
| |
| pin_desc[i].number = i; |
| /* Pin naming convention: P(bank_name)(bank_pin_number). */ |
| - pin_desc[i].name = kasprintf(GFP_KERNEL, "P%c%d", |
| - bank + 'A', line); |
| + pin_desc[i].name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "P%c%d", |
| + bank + 'A', line); |
| |
| group->name = group_names[i] = pin_desc[i].name; |
| group->pin = pin_desc[i].number; |
| diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c |
| index fad0e132ead84..ad01cc5798232 100644 |
| --- a/drivers/pinctrl/pinctrl-at91.c |
| +++ b/drivers/pinctrl/pinctrl-at91.c |
| @@ -1782,7 +1782,7 @@ static int at91_gpio_probe(struct platform_device *pdev) |
| } |
| |
| for (i = 0; i < chip->ngpio; i++) |
| - names[i] = kasprintf(GFP_KERNEL, "pio%c%d", alias_idx + 'A', i); |
| + names[i] = devm_kasprintf(&pdev->dev, GFP_KERNEL, "pio%c%d", alias_idx + 'A', i); |
| |
| chip->names = (const char *const *)names; |
| |
| -- |
| 2.39.2 |
| |